Skip to content

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Sep 15, 2025

This PR updates the custom styles API, adding toExternalHTML and parse. The motivation behind it is mainly to fix external HTML export for text/background color styles (see more about this in #1991).

TODO:

  • Fix TipTap mark internal representation in styleSpecs. We need to call the mark's renderHTML function in styleSpec.implementation.render, but it's not getting all the arguments it needs atm and throwing errors.
  • Fix typing.
  • Add changes to React API.
  • Updates snaps & check for expected output

Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
blocknote Error Error Sep 16, 2025 8:52am
blocknote-website Error Error Sep 16, 2025 8:52am

@nperez0111 nperez0111 merged commit 4a23da2 into tiptap-v3-again Sep 16, 2025
0 of 10 checks passed
@nperez0111 nperez0111 deleted the styles-api-update branch September 16, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants